Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve checking command existence #2436

Merged
merged 2 commits into from
Dec 14, 2022
Merged

fix: Improve checking command existence #2436

merged 2 commits into from
Dec 14, 2022

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Dec 14, 2022

Signed-off-by: Anatolii Bazko [email protected]

What does this PR do?

Improve check if command exists before running chectl tasks.
Double check with ignoring local non executable files.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#21884

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha tolusha requested a review from flacatus as a code owner December 14, 2022 07:57
@openshift-ci
Copy link

openshift-ci bot commented Dec 14, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Dec 14, 2022

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v10-chectl-e2e-olm-installer 6c6a52e link true /test v10-chectl-e2e-olm-installer

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha closed this Dec 14, 2022
@tolusha tolusha reopened this Dec 14, 2022
@tolusha tolusha merged commit 5fdabb1 into main Dec 14, 2022
@tolusha tolusha deleted the 21884 branch December 14, 2022 12:39
@devstudio-release
Copy link

Build 3.4 :: dsc_3.x/493: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.4 :: dsc_3.x/493: SUCCESS

3.4.0 CI

@che-bot che-bot added this to the 7.58 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants